Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add N&N for auto-expand of single child elements in tree viewers #171

Merged
merged 2 commits into from
May 27, 2024

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented May 23, 2024

Issue: eclipse-platform/eclipse.platform.ui#1063

PR: eclipse-platform/eclipse.platform.ui#1072

Also removes the empty SWT sections from the page for the 4.32 release.

@Wittmaxi
Copy link

This looks good to me - It is important that more people hear about this change so it can be

  1. applied to more views accross the IDE (in particular those mentionned in here)
  2. used consistently in places where a similar mechanism was implemented on a higher abstraction layer

@merks
Copy link
Contributor

merks commented May 27, 2024

@HeikoKlare

Is there something hold this up further?

@HeikoKlare
Copy link
Contributor Author

@merks No, I just wanted to give @Wittmaxi a chance to review this as he contributed the feature (and was on vacation until today). I was not aware of the timeline, I thought we have some more days for this. Sorry for that.

I have just added a commit that removes the empty parts in the ISV documentation. The page looks fine to me: https://htmlpreview.github.io/?https://github.com/HeikoKlare/www.eclipse.org-eclipse/blob/nn-platform-1063/news/4.32/platform_isv.html

@HeikoKlare HeikoKlare merged commit 5b90a8f into eclipse-platform:master May 27, 2024
1 check passed
@merks
Copy link
Contributor

merks commented May 27, 2024

I was not aware of a timeline last time either. 😢

The change looks good and the wording is good. 👍

@HeikoKlare HeikoKlare deleted the nn-platform-1063 branch May 27, 2024 10:22
@merks
Copy link
Contributor

merks commented May 27, 2024

FYI, I get fancy 👼 and run a local httpd server to see the changes locally:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants